Issue 11235060: Get rid of Dynamic.

Issue 11235060: Get rid of Dynamic. (Closed)

Created:
8 years, 2 months ago by Anton Muhin

Modified:
8 years, 2 months ago

Reviewers:
podivilov, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Get rid of Dynamic. R=podivilov@chromium.org,kasperl@google.com BUG=6187 Committed: https://code.google.com/p/dart/source/detail?r=13958

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -134 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View		27 chunks	+44 lines, -47 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		36 chunks	+50 lines, -51 lines	0 comments	Download
M	lib/html/scripts/generator.py	View		11 chunks	+20 lines, -20 lines	0 comments	Download
M	lib/html/scripts/systemhtml.py	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/html/scripts/systemnative.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/html/src/CrossFrameTypes.dart	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	lib/html/src/Serialization.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/html/src/dart2js_DOMImplementation.dart	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	lib/html/src/native_DOMImplementation.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/html/templates/html/impl/impl_EventTarget.darttemplate	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

https://codereview.chromium.org/11235060/diff/1/lib/html/dart2js/html_dart2js.dart File lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11235060/diff/1/lib/html/dart2js/html_dart2js.dart#newcode7370 lib/html/dart2js/html_dart2js.dart:7370: + dynamic fillStyle; we should varify those, but that's ...

8 years, 2 months ago (2012-10-23 12:21:01 UTC) #2

kasperl

LGTM, but the 'is dynamic' checks look fishy. https://codereview.chromium.org/11235060/diff/1/lib/html/dartium/html_dartium.dart File lib/html/dartium/html_dartium.dart (right): https://codereview.chromium.org/11235060/diff/1/lib/html/dartium/html_dartium.dart#newcode17821 lib/html/dartium/html_dartium.dart:17821: + ...

8 years, 2 months ago (2012-10-23 12:24:58 UTC) #3

Anton Muhin

8 years, 2 months ago (2012-10-23 12:32:54 UTC) #4

https://codereview.chromium.org/11235060/diff/1/lib/html/dartium/html_dartium...
File lib/html/dartium/html_dartium.dart (right):

https://codereview.chromium.org/11235060/diff/1/lib/html/dartium/html_dartium...
lib/html/dartium/html_dartium.dart:17821: +    if ((key_OR_range is dynamic ||
key_OR_range == null) && !?direction) {
On 2012/10/23 12:24:58, kasperl wrote:
> This still looks fishy. Everything is dynamic.

Agree, I'll address that in a separate CL

https://codereview.chromium.org/11235060/diff/1/lib/html/dartium/html_dartium...
lib/html/dartium/html_dartium.dart:44363: +  } catch(_) {
On 2012/10/23 12:24:58, kasperl wrote:
> Space between catch and (.

Done.

https://codereview.chromium.org/11235060/diff/1/lib/html/src/Serialization.dart
File lib/html/src/Serialization.dart (right):

https://codereview.chromium.org/11235060/diff/1/lib/html/src/Serialization.da...
lib/html/src/Serialization.dart:154: // TODO(floitsch): this should be new
HashMap<int, var|dynamic>()
On 2012/10/23 12:24:58, kasperl wrote:
> Remove var|.

Done.

https://codereview.chromium.org/11235060/diff/1/lib/html/src/native_DOMImplem...
File lib/html/src/native_DOMImplementation.dart (right):

https://codereview.chromium.org/11235060/diff/1/lib/html/src/native_DOMImplem...
lib/html/src/native_DOMImplementation.dart:112: } catch(_) {
On 2012/10/23 12:24:58, kasperl wrote:
> Space between catch and (.

Done.

Expand Messages | Collapse Messages