Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 11235059: Switch to new library syntax. (Closed)

Created:
8 years, 2 months ago by Anton Muhin
Modified:
8 years, 2 months ago
Reviewers:
vsm, podivilov, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -89 lines) Patch
M lib/html/dart2js/html_dart2js.dart View 58 chunks +60 lines, -3 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 58 chunks +61 lines, -4 lines 0 comments Download
M lib/html/scripts/idlparser_test.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M lib/html/scripts/systemhtml.py View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/html/templates/callback.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/dart2js/html_dart2js.darttemplate View 1 1 chunk +26 lines, -26 lines 0 comments Download
M lib/html/templates/html/dartium/html_dartium.darttemplate View 1 chunk +25 lines, -25 lines 0 comments Download
M lib/html/templates/html/impl/factoryprovider_Elements.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_AudioContext.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_CSSStyleDeclaration.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_CanvasElement.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_CanvasRenderingContext2D.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_CustomEvent.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_Document.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_DocumentFragment.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_Element.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_Event.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_EventTarget.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_HttpRequest.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_IDBKeyRange.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_LocalWindow.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_MouseEvent.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_MutationObserver.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_Node.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_NodeList.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
lib/html/templates/html/interface/interface_NodeSelector.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_Point.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_SVGElement.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_SVGSVGElement.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_ShadowRoot.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_Storage.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_Text.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_WebSocket.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/html/interface/interface_WheelEvent.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/html/templates/interface.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/copy_dart.py View 1 4 chunks +19 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Anton Muhin
8 years, 2 months ago (2012-10-23 11:52:39 UTC) #1
podivilov
lgtm https://codereview.chromium.org/11235059/diff/1/tools/copy_dart.py File tools/copy_dart.py (right): https://codereview.chromium.org/11235059/diff/1/tools/copy_dart.py#newcode126 tools/copy_dart.py:126: for importfile in library.imports: Maybe keep support for ...
8 years, 2 months ago (2012-10-23 11:57:55 UTC) #2
kasperl
https://codereview.chromium.org/11235059/diff/1/lib/html/templates/html/dart2js/html_dart2js.darttemplate File lib/html/templates/html/dart2js/html_dart2js.darttemplate (right): https://codereview.chromium.org/11235059/diff/1/lib/html/templates/html/dart2js/html_dart2js.darttemplate#newcode15 lib/html/templates/html/dart2js/html_dart2js.darttemplate:15: part '$AUXILIARY_DIR/CrossFrameTypes.dart'; As part of this (no pun intended) ...
8 years, 2 months ago (2012-10-23 11:58:38 UTC) #3
Anton Muhin
https://codereview.chromium.org/11235059/diff/1/lib/html/templates/html/dart2js/html_dart2js.darttemplate File lib/html/templates/html/dart2js/html_dart2js.darttemplate (right): https://codereview.chromium.org/11235059/diff/1/lib/html/templates/html/dart2js/html_dart2js.darttemplate#newcode15 lib/html/templates/html/dart2js/html_dart2js.darttemplate:15: part '$AUXILIARY_DIR/CrossFrameTypes.dart'; W/o VM support it's hard to ensure, ...
8 years, 2 months ago (2012-10-23 13:03:27 UTC) #4
kasperl
LGTM. Thanks, Anton!
8 years, 2 months ago (2012-10-23 13:04:28 UTC) #5
vsm
8 years, 2 months ago (2012-10-23 13:42:06 UTC) #6
lgtm!

Powered by Google App Engine
This is Rietveld 408576698