Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1123473005: Fix version solving in pub. (Closed)

Created:
5 years, 7 months ago by nweiz
Modified:
5 years, 7 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix version solving in pub. I deleted a line in r45508 because it had an unused variable, but it turned out that it also had relevant side-effects. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=45513

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 7 months ago (2015-05-04 22:12:43 UTC) #1
Bob Nystrom
lgtm
5 years, 7 months ago (2015-05-04 22:13:28 UTC) #2
nweiz
5 years, 7 months ago (2015-05-04 22:16:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45513 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698