Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 11234069: Removed a -d32 flag to dart_analyzer (fix for http://code.google.com/p/dart/issues/detail?id=5836) (Closed)

Created:
8 years, 2 months ago by devoncarew
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Removed a -d32 flag to dart_analyzer (fix for http://code.google.com/p/dart/issues/detail?id=5836) Quoted input to tr in dart_analyzer.sh (http://code.google.com/p/dart/issues/detail?id=6051) Changed dart_analyzer --version to report the new version format (not the old build revision format). Committed: https://code.google.com/p/dart/source/detail?r=14028

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M compiler/java/com/google/dart/compiler/DartCompiler.java View 1 chunk +6 lines, -6 lines 0 comments Download
M compiler/scripts/dart_analyzer.sh View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
devoncarew
8 years, 2 months ago (2012-10-23 23:17:39 UTC) #1
Siggi Cherem (dart-lang)
lgtm
8 years, 2 months ago (2012-10-23 23:27:03 UTC) #2
scheglov
8 years, 2 months ago (2012-10-24 02:18:03 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698