Issue 11234060: Update status file with co19 issue number.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11234060: Update status file with co19 issue number. (Closed)

Created:
8 years, 2 months ago by floitsch

Modified:
8 years, 2 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update status file with co19 issue number. Committed: https://code.google.com/p/dart/source/detail?r=13982

Patch Set 2 : Address comments. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+216 lines, -307 lines)			Patch
M	tests/co19/co19-compiler.status	View	1	1 chunk	+0 lines, -79 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1	1 chunk	+70 lines, -74 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	1 chunk	+73 lines, -77 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	1 chunk	+73 lines, -77 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

Thank you, LGTM (with two additional requests) https://codereview.chromium.org/11234060/diff/1/tests/co19/co19-compiler.status File tests/co19/co19-compiler.status (right): https://codereview.chromium.org/11234060/diff/1/tests/co19/co19-compiler.status#newcode214 tests/co19/co19-compiler.status:214: # The ...

8 years, 2 months ago (2012-10-23 18:16:35 UTC) #2

floitsch

8 years, 2 months ago (2012-10-23 18:22:23 UTC) #3

https://codereview.chromium.org/11234060/diff/1/tests/co19/co19-compiler.status
File tests/co19/co19-compiler.status (right):

https://codereview.chromium.org/11234060/diff/1/tests/co19/co19-compiler.stat...
tests/co19/co19-compiler.status:214: # The following tests use isOdd/isEven
functions instead of getters. co19 issue 277.
On 2012/10/23 18:16:35, ahe wrote:
> Could you remove the "section" comments as well? It takes me time to find and
> remove them when updating co19.

Done.

https://codereview.chromium.org/11234060/diff/1/tests/co19/co19-compiler.stat...
tests/co19/co19-compiler.status:215: LibTest/core/int/isOdd_A01_t01: Pass, OK #
co19 issue 277
On 2012/10/23 18:16:35, ahe wrote:
> As I mentioned, these aren't really helping. Could you just remove them?

Done.

Expand Messages | Collapse Messages

Issue 11234060: Update status file with co19 issue number. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments. #

Messages