Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1123323003: Fix or work around failing pub tests. (Closed)

Created:
5 years, 7 months ago by nweiz
Modified:
5 years, 7 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix or work around failing pub tests. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=45572

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/solver/version_solver.dart View 3 chunks +10 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/dependency.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/get/hosted/avoid_network_requests_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/version_solver_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
5 years, 7 months ago (2015-05-06 20:35:57 UTC) #1
Bob Nystrom
I assume these are short-term TODOs? LGTM.
5 years, 7 months ago (2015-05-06 20:39:01 UTC) #2
nweiz
On 2015/05/06 20:39:01, Bob Nystrom wrote: > I assume these are short-term TODOs? > > ...
5 years, 7 months ago (2015-05-06 20:40:38 UTC) #3
nweiz
5 years, 7 months ago (2015-05-06 20:40:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45572 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698