Issue 11233063: Move ObjectNotClosureException and ClosureArgumentMismatchException to patch file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11233063: Move ObjectNotClosureException and ClosureArgumentMismatchException to patch file. (Closed)

Created:
8 years, 2 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 2 months ago

Reviewers:
Mads Ager (google), Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move ObjectNotClosureException and ClosureArgumentMismatchException to patch file. They are no longer available in the core library, and are only used by the VM. Committed: https://code.google.com/p/dart/source/detail?r=13992

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove unrelated edit. #

Patch Set 3 : Moved misplaced co19 expectations to correct group #

Patch Set 4 : One more test failure which already failed in VM. #

Patch Set 5 : More test expectations. #

Patch Set 6 : checked mode test expectations. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -24 lines)			Patch
M	lib/core/exceptions.dart	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	runtime/lib/errors_patch.dart	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_entry.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/exceptions.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1 2 3 4 5	1 chunk	+18 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 2 3 4 5	1 chunk	+17 lines, -6 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2 3 4 5	2 chunks	+13 lines, -1 line	0 comments	Download
M	tools/utils/vim/syntax/dart.vim	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM https://codereview.chromium.org/11233063/diff/1/runtime/lib/errors_patch.dart File runtime/lib/errors_patch.dart (right): https://codereview.chromium.org/11233063/diff/1/runtime/lib/errors_patch.dart#newcode11 runtime/lib/errors_patch.dart:11: // Exceptions that should be NoSuchMethodError instead. If ...

8 years, 2 months ago (2012-10-23 14:38:04 UTC) #2

Lasse Reichstein Nielsen

8 years, 2 months ago (2012-10-23 16:29:17 UTC) #3

That would be http://code.google.com/p/dart/issues/detail?id=6124
I'll add a comment to also remove the classes when the VM is done using them.

Expand Messages | Collapse Messages