Issue 11233058: Update co19 to r397.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11233058: Update co19 to r397. (Closed)

Created:
8 years, 2 months ago by ahe

Modified:
8 years, 2 months ago

Reviewers:
Mads Ager (google), kasperl

CC:
reviews_dartlang.org, Ivan Posva, scheglov

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Update co19 to r397. Committed: https://code.google.com/p/dart/source/detail?r=13935

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+531 lines, -1076 lines)			Patch
M	dart/tests/co19/co19-compiler.status	View	11 chunks	+89 lines, -168 lines	0 comments	Download
M	dart/tests/co19/co19-dart2dart.status	View	23 chunks	+131 lines, -269 lines	0 comments	Download
M	dart/tests/co19/co19-dart2js.status	View	25 chunks	+156 lines, -305 lines	0 comments	Download
M	dart/tests/co19/co19-runtime.status	View	10 chunks	+138 lines, -330 lines	0 comments	Download
M	dart/tools/testing/dart/test_progress.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	dart/tools/testing/dart/test_runner.dart	View	2 chunks	+12 lines, -2 lines	0 comments	Download
M	deps/all.deps/DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	deps/standalone.deps/DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

Mads: please take a look at my changes to tools/testing/dart.

8 years, 2 months ago (2012-10-23 08:47:40 UTC) #1

Mads Ager (google)

8 years, 2 months ago (2012-10-23 08:52:37 UTC) #3

LGTM

I'm changing Process.kill to return a boolean right now. It will return false if
the process is already dead or the signal could not be delivered for some other
reason. Throwing an exception is not helpful as you can do nothing as a result.

Expand Messages | Collapse Messages