Issue 11233032: [core] cleanup === and !==

Issue 11233032: [core] cleanup === and !== (Closed)

Created:
8 years, 2 months ago by danrubel

Modified:
8 years, 2 months ago

Reviewers:
ahe, floitsch, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

[core] cleanup === and !== Committed: https://code.google.com/p/dart/source/detail?r=13878

Patch Set 3 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -74 lines)			Patch
M	lib/core/errors.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/core/exceptions.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/core/expect.dart	View	1 2	9 chunks	+9 lines, -9 lines	0 comments	Download
M	lib/coreimpl/arrays.dart	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/coreimpl/collections.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/coreimpl/date.dart	View	1 2	3 chunks	+6 lines, -6 lines	0 comments	Download
M	lib/coreimpl/future_implementation.dart	View	1 2	4 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/coreimpl/hash_map_set.dart	View	1 2	9 chunks	+11 lines, -9 lines	0 comments	Download
M	lib/coreimpl/linked_hash_map.dart	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	lib/coreimpl/options.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/coreimpl/queue.dart	View	1 2	8 chunks	+8 lines, -8 lines	0 comments	Download
M	lib/coreimpl/splay_tree.dart	View	1 2	8 chunks	+16 lines, -16 lines	0 comments	Download
M	lib/coreimpl/stopwatch_implementation.dart	View	1 2	3 chunks	+7 lines, -7 lines	0 comments	Download
M	lib/coreimpl/string_buffer.dart	View	1 2	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM if you address the comments below. https://codereview.chromium.org/11233032/diff/1/lib/core/expect.dart File lib/core/expect.dart (right): https://codereview.chromium.org/11233032/diff/1/lib/core/expect.dart#newcode26 lib/core/expect.dart:26: if (identical(actual, ...

8 years, 2 months ago (2012-10-22 09:05:21 UTC) #2

floitsch

After discussion with Peter: leave most of the identical. But please fix the 80chars. https://codereview.chromium.org/11233032/diff/1/lib/core/expect.dart ...

8 years, 2 months ago (2012-10-22 12:07:37 UTC) #3

danrubel

8 years, 2 months ago (2012-10-22 13:35:48 UTC) #5

https://codereview.chromium.org/11233032/diff/1/lib/coreimpl/hash_map_set.dart
File lib/coreimpl/hash_map_set.dart (right):

https://codereview.chromium.org/11233032/diff/1/lib/coreimpl/hash_map_set.dar...
lib/coreimpl/hash_map_set.dart:91: } else if ((insertionIndex < 0) &&
(identical(_DELETED_KEY, existingKey))) {
On 2012/10/22 12:07:37, floitsch wrote:
> On 2012/10/22 09:05:21, ahe wrote:
> > _DELETED_KEY == existingKey
> 
> I prefer identical too.
> Please make it fit on 80chars.

Done.

https://codereview.chromium.org/11233032/diff/1/lib/coreimpl/hash_map_set.dar...
lib/coreimpl/hash_map_set.dart:411: if (identical(_entries[_nextValidIndex],
HashMapImplementation._DELETED_KEY)) {
On 2012/10/22 12:07:37, floitsch wrote:
> On 2012/10/22 09:05:21, ahe wrote:
> > HashMapImplementation._DELETED_KEY == identical(_entries[_nextValidIndex]
> 
> ditto. Please make it fit on 80chars.

Done.

Expand Messages | Collapse Messages