Make script-insets obey their bounds, and other padding tweaks.

Make script-insets obey their bounds, and other padding tweaks.

R=turnidge@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45570

[rmacnak, 2015-05-06 01:33:43]

rmacnak@google.com changed reviewers:
+ turnidge@google.com

[rmacnak, 2015-05-06 01:33:44]

https://codereview.chromium.org/1123143002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/script_inset.html (right):

https://codereview.chromium.org/1123143002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/script_inset.html:26: max-width: 0;
Apparently this needs to be set for a table-cell to respect overflow.

[turnidge, 2015-05-06 07:14:42]

lgtm w/ questions/comments

https://codereview.chromium.org/1123143002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/script_inset.html (right):

https://codereview.chromium.org/1123143002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/script_inset.html:26: max-width: 0;
On 2015/05/06 01:33:44, rmacnak wrote:
> Apparently this needs to be set for a table-cell to respect overflow.

Do we want hidden or auto?  Will auto give us a scrollbar when we need it?

https://codereview.chromium.org/1123143002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/script_view.html (right):

https://codereview.chromium.org/1123143002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/script_view.html:24: <script-inset
id="scriptInset" script="{{ script }}"></script-inset>
Could we make script-inset accept a null for currentPos?  If so, we could drop
this <template if...>

https://codereview.chromium.org/1123143002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/view_footer.html (right):

https://codereview.chromium.org/1123143002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/view_footer.html:11: View documentation
What do you think of having a slightly smaller font size for these footer links?

[rmacnak, 2015-05-06 17:10:33]

https://codereview.chromium.org/1123143002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/script_inset.html (right):

https://codereview.chromium.org/1123143002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/script_inset.html:26: max-width: 0;
On 2015/05/06 07:14:42, turnidge wrote:
> On 2015/05/06 01:33:44, rmacnak wrote:
> > Apparently this needs to be set for a table-cell to respect overflow.
> 
> Do we want hidden or auto?  Will auto give us a scrollbar when we need it?

A scroll bar would be nice if it applied to the script inset as a block. If I
put overflow-x:auto here, each line has its own scroll bar. If I put
overflow-x:auto on the table, the lines again overflow the script inset. :(

https://codereview.chromium.org/1123143002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/script_view.html (right):

https://codereview.chromium.org/1123143002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/script_view.html:24: <script-inset
id="scriptInset" script="{{ script }}"></script-inset>
On 2015/05/06 07:14:42, turnidge wrote:
> Could we make script-inset accept a null for currentPos?  If so, we could drop
> this <template if...>

Hm, it already does. Dropped the template-if.

https://codereview.chromium.org/1123143002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/view_footer.html (right):

https://codereview.chromium.org/1123143002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/view_footer.html:11: View documentation
On 2015/05/06 07:14:42, turnidge wrote:
> What do you think of having a slightly smaller font size for these footer
links?

sg

[rmacnak, 2015-05-06 17:10:52]

Committed patchset #2 (id:20001) manually as 45570 (presubmit successful).