Issue 1123123002: Stop passing arguments to isInstanceOf.

Issue 1123123002: Stop passing arguments to isInstanceOf. (Closed)

Created:
5 years, 7 months ago by nweiz

Modified:
5 years, 7 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Stop passing arguments to isInstanceOf. Closes #104 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/7abe491649015474eff9a59dcb34a7d6206c8fa0

Patch Set 2 : Code review changes #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	test/backend/platform_selector/parser_test.dart	View	1	1 chunk	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

lgtm https://codereview.chromium.org/1123123002/diff/1/test/backend/platform_selector/parser_test.dart File test/backend/platform_selector/parser_test.dart (right): https://codereview.chromium.org/1123123002/diff/1/test/backend/platform_selector/parser_test.dart#newcode11 test/backend/platform_selector/parser_test.dart:11: new isInstanceOf<ConditionalNode>(); could be one line?

5 years, 7 months ago (2015-05-06 05:18:33 UTC) #2

nweiz

https://codereview.chromium.org/1123123002/diff/1/test/backend/platform_selector/parser_test.dart File test/backend/platform_selector/parser_test.dart (right): https://codereview.chromium.org/1123123002/diff/1/test/backend/platform_selector/parser_test.dart#newcode11 test/backend/platform_selector/parser_test.dart:11: new isInstanceOf<ConditionalNode>(); On 2015/05/06 05:18:33, kevmoo wrote: > could ...

5 years, 7 months ago (2015-05-06 18:12:21 UTC) #4

nweiz

5 years, 7 months ago (2015-05-06 18:12:31 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
7abe491649015474eff9a59dcb34a7d6206c8fa0 (presubmit successful).

Expand Messages | Collapse Messages