Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 11231043: Move FutureImpl and CompleterImpl from coreimpl to core, while also making them private. (Closed)

Created:
8 years, 2 months ago by Anders Johnsen
Modified:
8 years, 2 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, Mads Ager (google), Lasse Reichstein Nielsen
Visibility:
Public.

Description

Move FutureImpl and CompleterImpl from coreimpl to core, while also making them private. BUG= Committed: https://code.google.com/p/dart/source/detail?r=13968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -285 lines) Patch
M lib/core/core.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/core/corelib_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M lib/core/future.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + lib/core/future_impl.dart View 8 chunks +12 lines, -11 lines 0 comments Download
M lib/coreimpl/coreimpl.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/coreimpl/corelib_impl_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D lib/coreimpl/future_implementation.dart View 1 chunk +0 lines, -270 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Anders Johnsen
8 years, 2 months ago (2012-10-22 15:14:59 UTC) #1
floitsch
8 years, 2 months ago (2012-10-22 15:58:38 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698