Issue 11231024: Revert "Improvement on future: add stack trace to future failures."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11231024: Revert "Improvement on future: add stack trace to future failures." (Closed)

Created:
8 years, 2 months ago by Siggi Cherem (dart-lang)

Modified:
8 years, 2 months ago

Reviewers:
Bob Nystrom, floitsch, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Improvement on future: add stack trace to future failures." Some co19 tests need to be updated. Will reapply after fixing their status files. Committed: https://code.google.com/p/dart/source/detail?r=13850

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -33 lines)			Patch
M	lib/core/future.dart	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	lib/coreimpl/future_implementation.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/corelib/future_test.dart	View	8 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

8 years, 2 months ago (2012-10-20 00:41:42 UTC) #2

On 2012/10/20 00:34:18, Siggi Cherem (dart-lang) wrote:

lgtm

Expand Messages | Collapse Messages