Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 11230053: Propagate class-id through checked mode type checks. (Closed)

Created:
8 years, 2 months ago by Florian Schneider
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Propagate class-id through checked mode type checks. Committed: https://code.google.com/p/dart/source/detail?r=13969

Patch Set 1 #

Patch Set 2 : Fixed assert in cid propagation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M runtime/vm/intermediate_language.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Florian Schneider
8 years, 2 months ago (2012-10-23 13:53:33 UTC) #1
Vyacheslav Egorov (Google)
lgtm
8 years, 2 months ago (2012-10-23 13:55:16 UTC) #2
Florian Schneider
New version uploaded: Had to override GetPropagatedCid as well because of an assert triggered during ...
8 years, 2 months ago (2012-10-23 15:42:19 UTC) #3
Vyacheslav Egorov (Google)
8 years, 2 months ago (2012-10-23 15:44:00 UTC) #4
still lgtm

Powered by Google App Engine
This is Rietveld 408576698