Issue 11229067: Increase timeout to see if "timeout" errors on Windows bot goes away. Otherwise,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11229067: Increase timeout to see if "timeout" errors on Windows bot goes away. Otherwise, (Closed)

Created:
8 years, 2 months ago by Emily Fortuna

Modified:
8 years, 2 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Increase timeout to see if "timeout" errors on Windows bot goes away. Otherwise, the test framework is incorrectly calculating "timeouts" Committed: https://code.google.com/p/dart/source/detail?r=13986

Patch Set 1 : #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	tools/testing/dart/test_options.dart	View		1 chunk	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

It looks like the test framework may be incorrectly calculating "timeouts", possibly as a result ...

8 years, 2 months ago (2012-10-23 20:04:59 UTC) #1

Jennifer Messerly

8 years, 2 months ago (2012-10-23 21:05:55 UTC) #2

lgtm

https://codereview.chromium.org/11229067/diff/1001/tools/testing/dart/test_op...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/11229067/diff/1001/tools/testing/dart/test_op...
tools/testing/dart/test_options.dart:566: // TODO(ahe): Restore the timeout to 8
times the original timeout
might want to leave this TODO(efortuna)? (not that you'll be the one that fixes
it -- just that you can explain it). I dunno how Peter feels about having his
name added to TODOs, if ya'll have done this before, it's fine with me :)

Expand Messages | Collapse Messages