Issue 112283002: update pubspecs for pkg uploading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 112283002: update pubspecs for pkg uploading (Closed)

Created:
7 years ago by Jennifer Messerly

Modified:
7 years ago

Reviewers:
Siggi Cherem (dart-lang), sethladd

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

update pubspecs for pkg uploading R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=31053

Patch Set 2 : #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -15 lines)			Patch
M	pkg/csslib/pubspec.yaml	View	1	2 chunks	+2 lines, -2 lines	1 comment	Download
M	pkg/custom_element/pubspec.yaml	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/html_import/pubspec.yaml	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/logging/pubspec.yaml	View	1	1 chunk	+6 lines, -3 lines	0 comments	Download
M	pkg/mutation_observer/pubspec.yaml	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/template_binding/pubspec.yaml	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

also cleaned up the authors & min sdk version for the pubspecs I'm modifying

7 years ago (2013-12-11 01:29:15 UTC) #1

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/112283002/diff/20001/pkg/csslib/pubspec.yaml File pkg/csslib/pubspec.yaml (right): https://codereview.chromium.org/112283002/diff/20001/pkg/csslib/pubspec.yaml#newcode3 pkg/csslib/pubspec.yaml:3: author: "Polymer.dart Team <web-ui-dev@dartlang.org>" fix mailing list too ...

7 years ago (2013-12-11 01:35:41 UTC) #2

Jennifer Messerly

Hey Seth, If I recall correctly, you asked us to use a different list from ...

7 years ago (2013-12-11 01:39:12 UTC) #3

Jennifer Messerly

7 years ago (2013-12-11 01:41:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r31053 (presubmit successful).

Expand Messages | Collapse Messages

Issue 112283002: update pubspecs for pkg uploading (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages