Issue 11228025: Allow splitting at lifetime holes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11228025: Allow splitting at lifetime holes. (Closed)

Created:
8 years, 2 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 2 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow splitting at lifetime holes. If the allocation finger is moved past lifetime hole unwind pending interval to the start of the range before attempting to split. R=fschneider@google.com BUG=dart:6094 Committed: https://code.google.com/p/dart/source/detail?r=13874

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	runtime/vm/flow_graph_allocator.cc	View		1 chunk	+3 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

8 years, 2 months ago (2012-10-22 13:08:53 UTC) #2

LGTM.

https://codereview.chromium.org/11228025/diff/1/runtime/vm/flow_graph_allocat...
File runtime/vm/flow_graph_allocator.cc (right):

https://codereview.chromium.org/11228025/diff/1/runtime/vm/flow_graph_allocat...
runtime/vm/flow_graph_allocator.cc:1356: // Corner case. Split position can be
inside the lifetime hole or at its
did you mean: inside _a_ lifetime hole?

Expand Messages | Collapse Messages