Issue 11228022: Cache parsed functions when inlining.

Issue 11228022: Cache parsed functions when inlining. (Closed)

Created:
8 years, 2 months ago by zerny-google

Modified:
8 years, 2 months ago

Reviewers:
Kevin Millikin (Google), srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cache parsed functions when inlining. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=13882

Patch Set 3 : Zone allocated ParsedFunction #

Total comments: 1

Patch Set 4 : virtual #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -39 lines)			Patch
M	runtime/vm/code_descriptors_test.cc	View	1 2	2 chunks	+6 lines, -6 lines	0 comments	Download
M	runtime/vm/compiler.cc	View	1 2	2 chunks	+11 lines, -11 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	1 2 3	9 chunks	+83 lines, -9 lines	0 comments	Download
M	runtime/vm/parser.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/parser_test.cc	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/scopes.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/unit_test.cc	View	1 2	1 chunk	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

One comment.... http://codereview.chromium.org/11228022/diff/2001/runtime/vm/flow_graph_inliner.cc File runtime/vm/flow_graph_inliner.cc (right): http://codereview.chromium.org/11228022/diff/2001/runtime/vm/flow_graph_inliner.cc#newcode50 runtime/vm/flow_graph_inliner.cc:50: class CachedFunction : public ZoneAllocated { This ...

8 years, 2 months ago (2012-10-22 10:52:16 UTC) #2

Kevin Millikin (Google)

LGTM. http://codereview.chromium.org/11228022/diff/5001/runtime/vm/flow_graph_inliner.cc File runtime/vm/flow_graph_inliner.cc (right): http://codereview.chromium.org/11228022/diff/5001/runtime/vm/flow_graph_inliner.cc#newcode66 runtime/vm/flow_graph_inliner.cc:66: void VisitSequenceNode(SequenceNode* node) { Reset(node, node->label()); } I ...

8 years, 2 months ago (2012-10-22 13:56:29 UTC) #4

srdjan

8 years, 2 months ago (2012-10-22 15:46:08 UTC) #5

I am not sure that I see the benefit of this CL. Communicating with Kevin and
Ian offline.

Expand Messages | Collapse Messages