Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11228002: Rename OutOfMemoryException to OutOfMemoryError. (Closed)

Created:
8 years, 2 months ago by Lasse Reichstein Nielsen
Modified:
8 years, 2 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rename OutOfMemoryException to OutOfMemoryError. Also move ExceptionImplementation to core. Committed: https://code.google.com/p/dart/source/detail?r=13818

Patch Set 1 #

Total comments: 4

Patch Set 2 : Made ExceptionImplementation private. Rmoved references in tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -32 lines) Patch
M lib/core/errors.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M lib/core/exceptions.dart View 1 3 chunks +11 lines, -8 lines 0 comments Download
M lib/coreimpl/coreimpl.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/coreimpl/corelib_impl_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D lib/coreimpl/exceptions.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M runtime/lib/integers.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/tests/vm/dart/isolate_mirror_local_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/vm/exceptions.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/corelib/big_integer_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/exception_implementation_test.dart View 1 2 chunks +0 lines, -2 lines 0 comments Download
M tests/language/import_core_impl_no_prefix_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/out_of_memory_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/utils/vim/syntax/dart.vim View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
8 years, 2 months ago (2012-10-19 11:19:00 UTC) #1
Mads Ager (google)
https://codereview.chromium.org/11228002/diff/1/lib/core/exceptions.dart File lib/core/exceptions.dart (right): https://codereview.chromium.org/11228002/diff/1/lib/core/exceptions.dart#newcode11 lib/core/exceptions.dart:11: interface Exception default ExceptionImplementation { Can you make this ...
8 years, 2 months ago (2012-10-19 11:24:27 UTC) #2
Lasse Reichstein Nielsen
https://codereview.chromium.org/11228002/diff/1/lib/core/exceptions.dart File lib/core/exceptions.dart (right): https://codereview.chromium.org/11228002/diff/1/lib/core/exceptions.dart#newcode11 lib/core/exceptions.dart:11: interface Exception default ExceptionImplementation { Comment added to explain ...
8 years, 2 months ago (2012-10-19 12:15:04 UTC) #3
Mads Ager (google)
8 years, 2 months ago (2012-10-19 12:18:25 UTC) #4 
LGTM!

Powered by Google App Engine
This is Rietveld 408576698