Issue 11227024: Cleanup list-like interfaces generation.

Issue 11227024: Cleanup list-like interfaces generation. (Closed)

Created:
8 years, 2 months ago by podivilov

Modified:
8 years, 2 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cleanup list-like interfaces generation. R=antonm@google.com Committed: https://code.google.com/p/dart/source/detail?r=13876

Patch Set 1 #

Total comments: 3

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -158 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View	4 chunks	+4 lines, -4 lines	1 comment	Download
M	lib/html/dartium/html_dartium.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/html/idl/dart/dart.idl	View	1 chunk	+0 lines, -48 lines	2 comments	Download
M	lib/html/scripts/generator.py	View	6 chunks	+20 lines, -66 lines	0 comments	Download
M	lib/html/scripts/systemhtml.py	View	6 chunks	+28 lines, -36 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

podivilov

https://codereview.chromium.org/11227024/diff/1/lib/html/dart2js/html_dart2js.dart File lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11227024/diff/1/lib/html/dart2js/html_dart2js.dart#newcode31691 lib/html/dart2js/html_dart2js.dart:31691: +class _SourceBufferListImpl extends _EventTargetImpl implements SourceBufferList, JavaScriptIndexingBehavior native "*SourceBufferList" ...

8 years, 2 months ago (2012-10-22 13:29:09 UTC) #2

Anton Muhin

stv! https://codereview.chromium.org/11227024/diff/1/lib/html/idl/dart/dart.idl File lib/html/idl/dart/dart.idl (left): https://codereview.chromium.org/11227024/diff/1/lib/html/idl/dart/dart.idl#oldcode59 lib/html/idl/dart/dart.idl:59: DOMStringList implements sequence<DOMString>; what about this one?

8 years, 2 months ago (2012-10-22 13:30:21 UTC) #3

podivilov

8 years, 2 months ago (2012-10-22 14:09:18 UTC) #4

https://codereview.chromium.org/11227024/diff/1/lib/html/idl/dart/dart.idl
File lib/html/idl/dart/dart.idl (left):

https://codereview.chromium.org/11227024/diff/1/lib/html/idl/dart/dart.idl#ol...
lib/html/idl/dart/dart.idl:59: DOMStringList implements sequence<DOMString>;
On 2012/10/22 13:30:21, Anton Muhin wrote:
> what about this one?

Good catch!

Expand Messages | Collapse Messages