Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 11227021: Change StackOverflowException to be an Error. (Closed)

Created:
8 years, 2 months ago by Lasse Reichstein Nielsen
Modified:
8 years, 2 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change StackOverflowException to be an Error. Also change OutOfMemoryError to actually extend Error. Committed: https://code.google.com/p/dart/source/detail?r=13857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -16 lines) Patch
M lib/compiler/implementation/compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/lib/js_helper.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/core/errors.dart View 3 chunks +15 lines, -4 lines 0 comments Download
M lib/core/exceptions.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/tests/vm/dart/isolate_mirror_local_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/exceptions.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/stack_overflow_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein Nielsen
8 years, 2 months ago (2012-10-22 09:06:06 UTC) #1
floitsch
8 years, 2 months ago (2012-10-22 09:47:55 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698