Chromium Code Reviews

Issue 112253002: Release new version of unittest. Seems we got a couple fixes and the version was (Closed)

Created:
7 years ago by Siggi Cherem (dart-lang)
Modified:
7 years ago
Reviewers:
dgrove, Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Release new version of unittest. Seems we got a couple fixes and the version was never updated. One important fix was that an extra 'stack' variable was shadowing a parameter here: https://code.google.com/p/dart/source/detail?r=30322 R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=31052

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+1 line, -1 line)
M pkg/unittest/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
7 years ago (2013-12-11 01:00:02 UTC) #1
Siggi Cherem (dart-lang)
7 years ago (2013-12-11 01:12:57 UTC) #2
Jennifer Messerly
LGTM
7 years ago (2013-12-11 01:13:43 UTC) #3
Siggi Cherem (dart-lang)
7 years ago (2013-12-11 01:16:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r31052 (presubmit successful).

Powered by Google App Engine