Issue 11225056: Remove second sleep in pub and enable pub tests on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11225056: Remove second sleep in pub and enable pub tests on Windows. (Closed)

Created:
8 years, 2 months ago by Mads Ager (google)

Modified:
8 years, 2 months ago

Reviewers:
Bob Nystrom, Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove second sleep in pub and enable pub tests on Windows. After the inherit fix I cannot reproduce the other 7zip problem either so I'm removing the sleep call. All tests pass on my machine. Bob, could you test this with all of your migthty pub power and see if you can make it break? R=sgjesse@google.com,rnystrom@google.com BUG=dartbug.com/5910 Committed: https://code.google.com/p/dart/source/detail?r=13964

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -18 lines)			Patch
	M	utils/pub/hosted_source.dart	View		1 chunk	+1 line, -10 lines	0 comments	Download
	M	utils/tests/pub/pub.status	View		1 chunk	+3 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

On 2012/10/23 13:43:25, Søren Gjesse wrote: > lgtm LGTM too! I'll beat on it when ...

8 years, 2 months ago (2012-10-23 14:06:41 UTC) #3

Mads Ager (google)

8 years, 2 months ago (2012-10-23 14:08:05 UTC) #4

Thanks Bob! I had to disable the git tests again because they don't run on the
buildbot on WIndows. Looks like they are attempting to look for a git repo in
the wrong directory. Would be great to see if we can get those enabled too. I
filed an area-pub bug for those: dartbug.com/6191 I believe.

Expand Messages | Collapse Messages