Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 11225054: Remove more () from getters. (Closed)

Created:
8 years, 2 months ago by kasperl
Modified:
8 years, 2 months ago
Reviewers:
Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove more () from getters. Anton, there seems to be some unrelated changes put in the html_dartium.dart file as a result of me re-running the lib/html/scripts/go.sh script. Could you take a look at those too? R=antonm@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=13943

Patch Set 1 #

Patch Set 2 : Merge from master. #

Patch Set 3 : Merge again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -107 lines) Patch
M lib/compiler/implementation/lib/isolate_patch.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/html/dart2js/html_dart2js.dart View 77 chunks +95 lines, -95 lines 0 comments Download
M lib/html/scripts/systemhtml.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M lib/html/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +4 lines, -4 lines 0 comments Download
M lib/html/templates/html/dart2js/impl_LocalWindow.darttemplate View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/html/templates/html/dart2js/impl_SelectElement.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
8 years, 2 months ago (2012-10-23 09:32:11 UTC) #1
kasperl
Here's the diff for the changes to html_dartium.dart: @@ -20353,7 +20353,7 @@ abstract class LocalWindow ...
8 years, 2 months ago (2012-10-23 09:32:59 UTC) #2
Anton Muhin
8 years, 2 months ago (2012-10-23 09:44:24 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698