Issue 112243002: Some cleanups, fixes. Parts of the cid guessing CL that was revrted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 112243002: Some cleanups, fixes. Parts of the cid guessing CL that was revrted. (Closed)

Created:
7 years ago by srdjan

Modified:
7 years ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Some cleanups, fixes. Parts of the cid guessing CL that was revrted. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=31085

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -39 lines)			Patch
M	runtime/vm/compiler.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	3 chunks	+39 lines, -38 lines	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

LGTM. https://codereview.chromium.org/112243002/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/112243002/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode122 runtime/vm/flow_graph_optimizer.cc:122: if (NoneIsDynamic(class_ids)) { I'd prefer naming this helper ...

7 years ago (2013-12-11 10:41:08 UTC) #2

srdjan

https://codereview.chromium.org/112243002/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/112243002/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode122 runtime/vm/flow_graph_optimizer.cc:122: if (NoneIsDynamic(class_ids)) { On 2013/12/11 10:41:08, Florian Schneider wrote: ...

7 years ago (2013-12-11 21:54:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r31085 (presubmit successful).

Expand Messages | Collapse Messages

Issue 112243002: Some cleanups, fixes. Parts of the cid guessing CL that was revrted. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages