Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 112193002: VM: Make ObjectMirror.invoke support getters returning functions. (Closed)

Created:
7 years ago by rmacnak
Modified:
7 years ago
Reviewers:
gbracha, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

VM: Make ObjectMirror.invoke support getters returning functions. BUG=http://dartbug.com/15138 R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=31076

Patch Set 1 #

Patch Set 2 : version the test... #

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -7 lines) Patch
M runtime/lib/mirrors.cc View 3 chunks +111 lines, -7 lines 0 comments Download
M tests/lib/lib.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A tests/lib/mirrors/invoke_call_through_getter_test.dart View 1 1 chunk +139 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmacnak
7 years ago (2013-12-11 00:16:13 UTC) #1
siva
lgtm
7 years ago (2013-12-11 01:21:52 UTC) #2
rmacnak
7 years ago (2013-12-11 19:43:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r31076 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698