Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1121773003: Sort the containing method first in completions following super (Closed)

Created:
5 years, 7 months ago by danrubel
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Sort the containing method first in completions following super BUG=dartbug.com/22850 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=45539

Patch Set 1 #

Patch Set 2 : fix merge #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -10 lines) Patch
M pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart View 1 chunk +13 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 5 chunks +13 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/services/completion/prefixed_element_contributor_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 7 months ago (2015-05-05 19:19:22 UTC) #2
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-05 19:23:40 UTC) #3
danrubel
5 years, 7 months ago (2015-05-05 21:11:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 45539 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698