Move validation logic for constant evaluation into its own class.

Move validation logic for constant evaluation into its own class.

This will help facilitate some refactoring of constant evaluation that
needs to be done in order to prepare it for the new task model.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45527

[Paul Berry, 2015-05-04 23:06:42]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-05-05 00:22:47]

LGTM

https://codereview.chromium.org/1121313004/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/constant.dart (right):

https://codereview.chromium.org/1121313004/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/constant.dart:1338: [ConstantEvaluationValidator
validator, this._lexicalEnvironment])
It might be better to make these named parameters, given that there's no
requirement that a validator be provided if a lexical environment is provided.
On the other hand, "lexicalEnvironment" is a long name...

[Paul Berry, 2015-05-05 14:16:21]

https://codereview.chromium.org/1121313004/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/constant.dart (right):

https://codereview.chromium.org/1121313004/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/constant.dart:1338: [ConstantEvaluationValidator
validator, this._lexicalEnvironment])
On 2015/05/05 00:22:47, Brian Wilkerson wrote:
> It might be better to make these named parameters, given that there's no
> requirement that a validator be provided if a lexical environment is provided.
> On the other hand, "lexicalEnvironment" is a long name...

Done.

[Paul Berry, 2015-05-05 14:23:06]

Committed patchset #1 (id:1) manually as 45527 (presubmit successful).