Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1121233002: Add ConstantExpression.evaluate. (Closed)

Created:
5 years, 7 months ago by Johnni Winther
Modified:
5 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add ConstantExpression.evaluate. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=45687

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+822 lines, -27 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/constant_system_dart.dart View 2 chunks +23 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/constants/constant_system.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 28 chunks +228 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/constants/values.dart View 1 4 chunks +36 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/core_types.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_system_javascript.dart View 2 chunks +18 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/constant_expression_evaluate_test.dart View 1 1 chunk +239 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/constant_expression_test.dart View 1 1 chunk +247 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
Look at constants/expressions.dart and constants/constant_system.dart first.
5 years, 7 months ago (2015-05-04 10:01:16 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1121233002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1121233002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode2432 pkg/compiler/lib/src/compiler.dart:2432: InterfaceType get typeType => typeClass.computeType(compiler); Is 'rawType' not ...
5 years, 7 months ago (2015-05-11 12:48:09 UTC) #3
Johnni Winther
https://codereview.chromium.org/1121233002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1121233002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode2432 pkg/compiler/lib/src/compiler.dart:2432: InterfaceType get typeType => typeClass.computeType(compiler); On 2015/05/11 12:48:08, karlklose ...
5 years, 7 months ago (2015-05-11 13:59:46 UTC) #4
Johnni Winther
5 years, 7 months ago (2015-05-11 14:34:54 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 45687 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698