Issue 112103007: Trace static tear-off closures.

Issue 112103007: Trace static tear-off closures. (Closed)

Created:
7 years ago by ngeoffray

Modified:
7 years ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Trace static tear-off closures. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=31272

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -21 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/inferrer/closure_tracer.dart	View		4 chunks	+31 lines, -12 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart	View		5 chunks	+14 lines, -9 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/inferrer/type_graph_nodes.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	tests/compiler/dart2js/closure_tracer_test.dart	View	1	1 chunk	+120 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/112103007/diff/1/tests/compiler/dart2js/closure_tracer_test.dart File tests/compiler/dart2js/closure_tracer_test.dart (right): https://codereview.chromium.org/112103007/diff/1/tests/compiler/dart2js/closure_tracer_test.dart#newcode85 tests/compiler/dart2js/closure_tracer_test.dart:85: testStaticClosure2(); Add test for static method on class ...

7 years ago (2013-12-19 13:33:33 UTC) #2

ngeoffray

Thanks Kasper. https://codereview.chromium.org/112103007/diff/1/tests/compiler/dart2js/closure_tracer_test.dart File tests/compiler/dart2js/closure_tracer_test.dart (right): https://codereview.chromium.org/112103007/diff/1/tests/compiler/dart2js/closure_tracer_test.dart#newcode85 tests/compiler/dart2js/closure_tracer_test.dart:85: testStaticClosure2(); On 2013/12/19 13:33:34, kasperl wrote: > ...

7 years ago (2013-12-19 13:39:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r31272 (presubmit successful).

Expand Messages | Collapse Messages