Issue 1120313004: Get memento objects from tasks, remember in cache and pass back to tasks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1120313004: Get memento objects from tasks, remember in cache and pass back to tasks. (Closed)

Created:
5 years, 7 months ago by scheglov

Modified:
5 years, 7 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Get memento objects from tasks, remember in cache and pass back to tasks. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45496

Patch Set 1 #

Total comments: 2

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+141 lines, -33 lines)			Patch
M	pkg/analyzer/lib/src/context/cache.dart	View	4 chunks	+21 lines, -2 lines	1 comment	Download
M	pkg/analyzer/lib/src/task/driver.dart	View	6 chunks	+15 lines, -6 lines	1 comment	Download
M	pkg/analyzer/lib/src/task/model.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/task/model.dart	View	3 chunks	+13 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/src/context/cache_test.dart	View	3 chunks	+14 lines, -3 lines	0 comments	Download
M	pkg/analyzer/test/src/task/driver_test.dart	View	13 chunks	+55 lines, -14 lines	0 comments	Download
M	pkg/analyzer/test/src/task/model_test.dart	View	5 chunks	+12 lines, -5 lines	0 comments	Download
M	pkg/analyzer/test/src/task/test_support.dart	View	3 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1120313004/diff/1/pkg/analyzer/lib/src/context/cache.dart File pkg/analyzer/lib/src/context/cache.dart (right): https://codereview.chromium.org/1120313004/diff/1/pkg/analyzer/lib/src/context/cache.dart#newcode840 pkg/analyzer/lib/src/context/cache.dart:840: dynamic memento; nit: I generally prefer 'Object' over ...

5 years, 7 months ago (2015-05-04 16:22:10 UTC) #2

scheglov

5 years, 7 months ago (2015-05-04 17:13:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 45496 (presubmit successful).

Expand Messages | Collapse Messages