Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 11200003: Change bidi_utils and bidi_formatter for new optional parameters. (Closed)

Created:
8 years, 2 months ago by regis
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change bidi_utils and bidi_formatter for new optional parameters. Committed: https://code.google.com/p/dart/source/detail?r=13793

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -60 lines) Patch
M pkg/intl/lib/bidi_formatter.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M pkg/intl/lib/bidi_utils.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/intl/test/bidi_format_test.dart View 3 chunks +48 lines, -37 lines 0 comments Download
M pkg/intl/test/bidi_utils_test.dart View 5 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
regis
Nicolas, Either something is wrong with this cl, or this dart2js issue is valid: http://code.google.com/p/dart/issues/detail?id=6015 ...
8 years, 2 months ago (2012-10-17 20:56:02 UTC) #1
regis
I just notice that Nicolas is in vacation. Thanks Peter! -- Regis
8 years, 2 months ago (2012-10-17 21:05:11 UTC) #2
regis
Thank you Peter for fixing the related dart2js bug. Adding Anton as a reviewer, since ...
8 years, 2 months ago (2012-10-18 16:42:44 UTC) #3
ahe
I think Emily and Alan are the best to review this code.
8 years, 2 months ago (2012-10-18 16:44:31 UTC) #4
Alan Knight
LGTM The only real question seems to be if the intent is for those to ...
8 years, 2 months ago (2012-10-18 18:05:28 UTC) #5
regis
On 2012/10/18 18:05:28, Alan Knight wrote: > LGTM > > The only real question seems ...
8 years, 2 months ago (2012-10-18 18:35:39 UTC) #6
Emily Fortuna
8 years, 2 months ago (2012-10-18 21:33:47 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698