Remove built-in identifier 'negate' from VM

Remove built-in identifier 'negate' from VM

Keep the token kNEGATE for the backend to distinguish between
unary and binary - operator.
Committed: https://code.google.com/p/dart/source/detail?r=13700

[srdjan, 2012-10-16 19:43:41]

LGTM with questions.

http://codereview.chromium.org/11199002/diff/9001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/11199002/diff/9001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:6616: return token == Token::kINCR || token ==
Token::kDECR;
Does this belong into class Token with all the other IsXXX?

http://codereview.chromium.org/11199002/diff/9001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:6624: (token == Token::kBIT_NOT);
Why does it differ from Token::IsPrefixOperator?

[hausner, 2012-10-16 20:19:44]

Thanks!

http://codereview.chromium.org/11199002/diff/9001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/11199002/diff/9001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:6616: return token == Token::kINCR || token ==
Token::kDECR;
On 2012/10/16 19:43:41, srdjan wrote:
> Does this belong into class Token with all the other IsXXX?

I prefer not to have these functions in class Token. This function interprets
some meaning into the tokens, whereas the Token class should be a strictly
textual abstraction. I actually don't like the IsXXXOperator functions in Token.

http://codereview.chromium.org/11199002/diff/9001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:6624: (token == Token::kBIT_NOT);
On 2012/10/16 19:43:41, srdjan wrote:
> Why does it differ from Token::IsPrefixOperator?

Because this function is called before the parser replaces kSUB with kNEGATE.
And eliminates kTIGHTADD altogether. The Token::IsXXX is used in the backend,
after the substitutions.

[ahe, 2012-10-17 12:26:32]

I'm not sure it was intentional, but this CL fixed snapshotting for dart2js.
Awesome!

Before this CL, dart2js with snapshotting would crash like this:

$ ./xcodebuild/ReleaseIA32/gen_snapshot --script_snapshot=dart2js.snapshot
lib/compiler/implementation/dart2js.dart && ./xcodebuild/ReleaseIA32/dart
--use_script_snapshot=dart2js.snapshot lib/compiler/implementation/dart2js.dart
tests/language/arithmetic_test.dart
.../dart/runtime/vm/object.cc:9803: error: unreachable code
Abort trap

After this CL, dart2js pass all language tests.