Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 11196025: Add an error for obsolete raw strings (issue 4815) (Closed)

Created:
8 years, 2 months ago by Brian Wilkerson
Modified:
8 years, 2 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add an error for obsolete raw strings (issue 4815) Committed: https://code.google.com/p/dart/source/detail?r=13780

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M compiler/java/com/google/dart/compiler/parser/DartScanner.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java View 1 chunk +6 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Brian Wilkerson
I believe that the VM no longer accepts the old syntax, so generating an error ...
8 years, 2 months ago (2012-10-17 18:20:02 UTC) #1
danrubel
lgtm http://codereview.chromium.org/11196025/diff/1/compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java File compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java (right): http://codereview.chromium.org/11196025/diff/1/compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java#newcode359 compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java:359: parseExpectWarnings( Perhaps it should be an error rather ...
8 years, 2 months ago (2012-10-17 21:55:35 UTC) #2
danrubel
http://codereview.chromium.org/11196025/diff/1/compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java File compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java (right): http://codereview.chromium.org/11196025/diff/1/compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java#newcode359 compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java:359: parseExpectWarnings( On 2012/10/17 21:55:35, danrubel wrote: > Perhaps it ...
8 years, 2 months ago (2012-10-17 21:57:17 UTC) #3
scheglov
8 years, 2 months ago (2012-10-18 01:13:50 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698