Issue 11195007: Add value tests to intrinisics GrowableArray _setData and setLength. Thos are private native method…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11195007: Add value tests to intrinisics GrowableArray _setData and setLength. Thos are private native method… (Closed)

Created:
8 years, 2 months ago by srdjan

Modified:
8 years, 2 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add value tests to intrinisics GrowableArray _setData and setLength. Thos are private native methods that could be invoked via mirrors with incorrect values. Committed: https://code.google.com/p/dart/source/detail?r=13704

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -6 lines)			Patch
	M	runtime/vm/intrinsifier_ia32.cc	View		2 chunks	+12 lines, -3 lines	0 comments	Download
	M	runtime/vm/intrinsifier_x64.cc	View	1	2 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/11195007/diff/1/runtime/vm/intrinsifier_x64.cc File runtime/vm/intrinsifier_x64.cc (right): https://codereview.chromium.org/11195007/diff/1/runtime/vm/intrinsifier_x64.cc#newcode367 runtime/vm/intrinsifier_x64.cc:367: __ movq(RAX, Address(RSP, + 2 * kWordSize)); // ...

8 years, 2 months ago (2012-10-16 21:28:14 UTC) #2

srdjan

8 years, 2 months ago (2012-10-16 21:39:39 UTC) #3

https://codereview.chromium.org/11195007/diff/1/runtime/vm/intrinsifier_x64.cc
File runtime/vm/intrinsifier_x64.cc (right):

https://codereview.chromium.org/11195007/diff/1/runtime/vm/intrinsifier_x64.c...
runtime/vm/intrinsifier_x64.cc:367: __ movq(RAX, Address(RSP, + 2 * kWordSize));
 // Growable array.
On 2012/10/16 21:28:15, siva wrote:
> This line could go just above the StoreIntoObject(..) code similar to how you
do
> it in the IA32 case?

Done.

Expand Messages | Collapse Messages