Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 11194052: Update status for jsshell to make the builders green. (Closed)

Created:
8 years, 2 months ago by ricow1
Modified:
8 years, 1 month ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update status for jsshell to make the builders green. Committed: https://code.google.com/p/dart/source/detail?r=14073

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -10 lines) Patch
M tests/co19/co19-dart2js.status View 1 2 5 chunks +26 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_foreign/dart2js_foreign.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/corelib.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
https://codereview.chromium.org/11194052/diff/1/tests/corelib/corelib.status File tests/corelib/corelib.status (right): https://codereview.chromium.org/11194052/diff/1/tests/corelib/corelib.status#newcode15 tests/corelib/corelib.status:15: unicode_test: Fail We should have a bug for this!
8 years, 2 months ago (2012-10-18 12:19:40 UTC) #1
ahe
LGTM, but it would be great if you could restore the classifications in co19. https://codereview.chromium.org/11194052/diff/1/tests/co19/co19-dart2js.status ...
8 years, 2 months ago (2012-10-18 12:44:43 UTC) #2
ricow1
https://codereview.chromium.org/11194052/diff/1/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (left): https://codereview.chromium.org/11194052/diff/1/tests/co19/co19-dart2js.status#oldcode746 tests/co19/co19-dart2js.status:746: Language/10_Expressions/14_Function_Invocation/4_Function_Expression_Invocation_A05_t02: Fail # TypeError: Object #<C> has no method ...
8 years, 2 months ago (2012-10-18 12:54:30 UTC) #3
ricow1
PTAL, rebased and updated
8 years, 1 month ago (2012-10-25 10:25:29 UTC) #4
ahe
8 years, 1 month ago (2012-10-25 12:44:04 UTC) #5
LGTM!

Powered by Google App Engine
This is Rietveld 408576698