Issue 11194033: Enable constructor name check by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11194033: Enable constructor name check by default (Closed)

Created:
8 years, 2 months ago by hausner

Modified:
8 years, 2 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Enable constructor name check by default Remove the runtime flag that turns on the name check for named constructors. Eliminate obsolete test and test case. Committed: https://code.google.com/p/dart/source/detail?r=13755

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -45 lines)			Patch
M	runtime/vm/parser.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
D	tests/language/named_constructor_test.dart	View	1	1 chunk	+0 lines, -25 lines	0 comments	Download
M	tests/language/naming_test.dart	View	1	2 chunks	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM http://codereview.chromium.org/11194033/diff/1/tests/language/named_constructor_test.dart File tests/language/named_constructor_test.dart (left): http://codereview.chromium.org/11194033/diff/1/tests/language/named_constructor_test.dart#oldcode25 tests/language/named_constructor_test.dart:25: } Why not make this test a negative ...

8 years, 2 months ago (2012-10-17 19:01:36 UTC) #2

hausner

8 years, 2 months ago (2012-10-17 19:05:50 UTC) #3

Thank you.

http://codereview.chromium.org/11194033/diff/1/tests/language/named_construct...
File tests/language/named_constructor_test.dart (left):

http://codereview.chromium.org/11194033/diff/1/tests/language/named_construct...
tests/language/named_constructor_test.dart:25: }
On 2012/10/17 19:01:36, regis wrote:
> Why not make this test a negative test? Or is this covered by co19?

It's covered by co19 test 6_Constructors_A01_t01

Expand Messages | Collapse Messages