Issue 11193024: The snapshot buffer was being released too early resulting in weird crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11193024: The snapshot buffer was being released too early resulting in weird crashes. (Closed)

Created:
8 years, 2 months ago by siva

Modified:
8 years, 2 months ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

The snapshot buffer was being released too early resulting in weird crashes. Committed: https://code.google.com/p/dart/source/detail?r=13749

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	runtime/bin/gen_snapshot.cc	View		2 chunks	+2 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

https://codereview.chromium.org/11193024/diff/1/runtime/bin/gen_snapshot.cc File runtime/bin/gen_snapshot.cc (right): https://codereview.chromium.org/11193024/diff/1/runtime/bin/gen_snapshot.cc#newcode362 runtime/bin/gen_snapshot.cc:362: free(error); "Leaking" the snapshot_buffer here.

8 years, 2 months ago (2012-10-18 05:45:52 UTC) #3

siva

8 years, 2 months ago (2012-10-18 17:55:42 UTC) #4

https://codereview.chromium.org/11193024/diff/1/runtime/bin/gen_snapshot.cc
File runtime/bin/gen_snapshot.cc (right):

https://codereview.chromium.org/11193024/diff/1/runtime/bin/gen_snapshot.cc#n...
runtime/bin/gen_snapshot.cc:362: free(error);
Fixing in a new CL.

On 2012/10/18 05:45:52, Ivan Posva wrote:
> "Leaking" the snapshot_buffer here.

Expand Messages | Collapse Messages