Issue 11192074: Fix bigint modulo operation. Fixes bug 6056

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11192074: Fix bigint modulo operation. Fixes bug 6056 (Closed)

Created:
8 years, 2 months ago by srdjan

Modified:
8 years, 2 months ago

Reviewers:
Florian Schneider, floitsch

CC:
reviews_dartlang.org, floitsch

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bigint modulo operation. Fixes bug 6056 Committed: https://code.google.com/p/dart/source/detail?r=13823

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -5 lines)			Patch
	M	runtime/vm/bigint_operations.cc	View	1	1 chunk	+11 lines, -3 lines	0 comments	Download
	M	tests/corelib/big_integer_vm_test.dart	View	1	3 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/11192074/diff/1/runtime/vm/bigint_operations.cc File runtime/vm/bigint_operations.cc (right): https://codereview.chromium.org/11192074/diff/1/runtime/vm/bigint_operations.cc#newcode783 runtime/vm/bigint_operations.cc:783: if (BigintOperations::Compare(remainder, zero) == -1) { if (remainder.isNegative()) ...

8 years, 2 months ago (2012-10-19 08:18:54 UTC) #2

srdjan

8 years, 2 months ago (2012-10-19 14:56:01 UTC) #3

Also added tests.

https://codereview.chromium.org/11192074/diff/1/runtime/vm/bigint_operations.cc
File runtime/vm/bigint_operations.cc (right):

https://codereview.chromium.org/11192074/diff/1/runtime/vm/bigint_operations....
runtime/vm/bigint_operations.cc:783: if (BigintOperations::Compare(remainder,
zero) == -1) {
On 2012/10/19 08:18:54, floitsch wrote:
> if (remainder.isNegative())

Done.

https://codereview.chromium.org/11192074/diff/1/runtime/vm/bigint_operations....
runtime/vm/bigint_operations.cc:784: if (BigintOperations::Compare(b, zero) ==
-1) {
On 2012/10/19 08:18:54, floitsch wrote:
> if (b.isNegative())

Done.

Expand Messages | Collapse Messages

Issue 11192074: Fix bigint modulo operation. Fixes bug 6056 (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages