Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 11192038: Skip package_isolate_test in dart2js (Closed)

Created:
8 years, 2 months ago by justinfagnani
Modified:
8 years, 2 months ago
Reviewers:
kasperl, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tests/standalone/standalone.status View 1 2 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
siva
https://codereview.chromium.org/11192038/diff/2001/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/11192038/diff/2001/tests/standalone/standalone.status#newcode56 tests/standalone/standalone.status:56: package/package_isolate_test: Skip # spawnUri does not work in dart2js ...
8 years, 2 months ago (2012-10-17 19:51:40 UTC) #1
justinfagnani
https://codereview.chromium.org/11192038/diff/2001/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/11192038/diff/2001/tests/standalone/standalone.status#newcode56 tests/standalone/standalone.status:56: package/package_isolate_test: Skip # spawnUri does not work in dart2js ...
8 years, 2 months ago (2012-10-17 19:57:24 UTC) #2
siva
lgtm
8 years, 2 months ago (2012-10-18 18:22:46 UTC) #3
kasperl
8 years, 2 months ago (2012-10-19 11:55:19 UTC) #4
DBC:

https://codereview.chromium.org/11192038/diff/8001/tests/standalone/standalon...
File tests/standalone/standalone.status (right):

https://codereview.chromium.org/11192038/diff/8001/tests/standalone/standalon...
tests/standalone/standalone.status:56: package/package_isolate_test: Skip #
spawnUri does not work in dart2js. See issue 3051
We should be careful with the skipping, so if it consistently fails at least
consider marking is as such (Fail).

Powered by Google App Engine
This is Rietveld 408576698