Issue 11191043: Third round of cleanups for new optional parameter semantics.

Issue 11191043: Third round of cleanups for new optional parameter semantics. (Closed)

Created:
8 years, 2 months ago by regis

Modified:
8 years, 2 months ago

Reviewers:
Lasse Reichstein Nielsen, Anton Muhin

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Third round of cleanups for new optional parameter semantics. Committed: https://code.google.com/p/dart/source/detail?r=13782

Patch Set 3 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -17 lines)			Patch
M	lib/compiler/implementation/ssa/builder.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/nodes.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/types/concrete_types_inferrer.dart	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/language/call_operator_test.dart	View	1 2	2 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/language/constructor5_test.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	1 2	1 chunk	+18 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

DBC https://codereview.chromium.org/11191043/diff/3001/lib/html/dart2js/html_dart2js.dart File lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11191043/diff/3001/lib/html/dart2js/html_dart2js.dart#newcode20403 lib/html/dart2js/html_dart2js.dart:20403: + int clientX, int clientY, int button, {bool ...

8 years, 2 months ago (2012-10-18 09:37:06 UTC) #2

regis

8 years, 2 months ago (2012-10-18 15:05:43 UTC) #4

Thanks!

This transition to the new semantics now depends on dartium being cleaned up
(Anton is working on it) and on a dart2js bug being fixed
(http://code.google.com/p/dart/issues/detail?id=6015).

Cheers,
Regis

https://codereview.chromium.org/11191043/diff/3001/lib/html/dart2js/html_dart...
File lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11191043/diff/3001/lib/html/dart2js/html_dart...
lib/html/dart2js/html_dart2js.dart:20403: +      int clientX, int clientY, int
button, {bool canBubble: true,
On 2012/10/18 09:37:06, Anton Muhin wrote:
> this and html_dartium are autogenerated, so it's useless to change them.
> 
> Overall, I hope that html tests should pass when new syntax is forced (at
least
> it was the case two days ago) and I am working on migrating to named
parameters
> where it's needed.

It's what I suspected, but I did not see the actual source. I guess it is in the
dartium tree? I'll revert these, but we won't be able to enforce the new
semantics until this is fixed on the dartium side.

Expand Messages | Collapse Messages