Issue 11191026: Unify formatting of parameters in interfaces and implementing classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11191026: Unify formatting of parameters in interfaces and implementing classes. (Closed)

Created:
8 years, 2 months ago by Anton Muhin

Modified:
8 years, 2 months ago

Reviewers:
podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Unify formatting of parameters in interfaces and implementing classes. R=podivilov@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=13744

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+116 lines, -131 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View	11 chunks	+12 lines, -12 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View	78 chunks	+80 lines, -80 lines	0 comments	Download
M	lib/html/scripts/generator.py	View	4 chunks	+15 lines, -30 lines	2 comments	Download
M	lib/html/scripts/systemhtml.py	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	lib/html/scripts/systemnative.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

podivilov

lgtm https://codereview.chromium.org/11191026/diff/1/lib/html/scripts/generator.py File lib/html/scripts/generator.py (right): https://codereview.chromium.org/11191026/diff/1/lib/html/scripts/generator.py#newcode362 lib/html/scripts/generator.py:362: def ParametersAsArgumentList(self, parameter_count = None): Please move back ...

8 years, 2 months ago (2012-10-17 14:21:16 UTC) #2

Anton Muhin

8 years, 2 months ago (2012-10-17 14:26:30 UTC) #3

https://codereview.chromium.org/11191026/diff/1/lib/html/scripts/generator.py
File lib/html/scripts/generator.py (right):

https://codereview.chromium.org/11191026/diff/1/lib/html/scripts/generator.py...
lib/html/scripts/generator.py:362: def ParametersAsArgumentList(self,
parameter_count = None):
On 2012/10/17 14:21:16, podivilov wrote:
> Please move back to reduce the diff.

Cannot, it's a single function :)

Expand Messages | Collapse Messages