Issue 11191024: Refactor common functionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11191024: Refactor common functionality. (Closed)

Created:
8 years, 2 months ago by Anton Muhin

Modified:
8 years, 2 months ago

Reviewers:
podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Refactor common functionality. R=podivilov@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=13733

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -17 lines)			Patch
	M	lib/html/scripts/generator.py	View		3 chunks	+9 lines, -17 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

https://codereview.chromium.org/11191024/diff/1/lib/html/scripts/generator.py File lib/html/scripts/generator.py (right): https://codereview.chromium.org/11191024/diff/1/lib/html/scripts/generator.py#newcode371 lib/html/scripts/generator.py:371: def _FormatParams(self, params, rename_type, provide_comments): we can simplify logic ...

8 years, 2 months ago (2012-10-17 12:30:16 UTC) #2

podivilov

8 years, 2 months ago (2012-10-17 12:38:04 UTC) #3

lgtm

https://codereview.chromium.org/11191024/diff/1/lib/html/scripts/generator.py
File lib/html/scripts/generator.py (right):

https://codereview.chromium.org/11191024/diff/1/lib/html/scripts/generator.py...
lib/html/scripts/generator.py:371: def _FormatParams(self, params, rename_type,
provide_comments):
On 2012/10/17 12:30:16, Anton Muhin wrote:
> we can simplify logic even further if we unify interface and implementation
> declarations which looks like a good thing imho

I agree.

Expand Messages | Collapse Messages