Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 11191002: Optimize type checks for boolean expressions using class-id information. (Closed)

Created:
8 years, 2 months ago by Florian Schneider
Modified:
8 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Optimize type checks for boolean expressions using class-id information. This CL adds a canonicalization pass for AssertBoolean instructions. If the input class id is guaranteed to be bool, the check can be eliminated. Committed: https://code.google.com/p/dart/source/detail?r=13683

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M runtime/vm/intermediate_language.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Florian Schneider
8 years, 2 months ago (2012-10-16 15:41:47 UTC) #1
regis
8 years, 2 months ago (2012-10-16 15:44:10 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698