Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 111903003: Add license file to csslib so we can upload directly from the bleeding_edge (Closed)

Created:
7 years ago by Siggi Cherem (dart-lang)
Modified:
7 years ago
Reviewers:
nweiz, terry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add license file to csslib so we can upload directly from the bleeding_edge directory. R=terry@google.com Committed: https://code.google.com/p/dart/source/detail?r=31030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + pkg/csslib/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Siggi Cherem (dart-lang)
7 years ago (2013-12-10 17:40:42 UTC) #1
terry
lgtm
7 years ago (2013-12-10 17:45:36 UTC) #2
Siggi Cherem (dart-lang)
Committed patchset #1 manually as r31030 (presubmit successful).
7 years ago (2013-12-10 17:50:20 UTC) #3
nweiz
On 2013/12/10 17:50:20, Siggi Cherem (dart-lang) wrote: > Committed patchset #1 manually as r31030 (presubmit ...
7 years ago (2013-12-10 19:27:41 UTC) #4
Siggi Cherem (dart-lang)
7 years ago (2013-12-10 21:04:57 UTC) #5
Message was sent while issue was closed.
On 2013/12/10 19:27:41, nweiz wrote:
> On 2013/12/10 17:50:20, Siggi Cherem (dart-lang) wrote:
> > Committed patchset #1 manually as r31030 (presubmit successful).
> 
> We don't usually have a LICENSE file directly in pkg packages, since they're
> usually published via tools/publish_pkg.py.

mmm... we seem to be doing this also for polymer, observe, template_binding and
other related packages.

I thought that the publish_pkg.py was mainly used before to ensure you couldn't
publish from bleeding_edge and automatically assign versions, but that we were
going to stop using it now. I personally prefer if we can simply just call
pub-lish from a package directory. One less thing to remember :).

Powered by Google App Engine
This is Rietveld 408576698