Issue 11189101: Complete renaming of ie bots to ie9, to add ie10.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11189101: Complete renaming of ie bots to ie9, to add ie10. (Closed)

Created:
8 years, 2 months ago by Emily Fortuna

Modified:
8 years, 2 months ago

Reviewers:
ricow1, Bill Hesse

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Complete renaming of ie bots to ie9, to add ie10. Committed: https://code.google.com/p/dart/source/detail?r=13908

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -14 lines)			Patch
M	tools/testing/dart/test_options.dart	View	1	5 chunks	+8 lines, -6 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	utils/compiler/buildbot.py	View	1	3 chunks	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

This can go in after the corresponding Chromium CL https://codereview.chromium.org/11227012/ goes in.

8 years, 2 months ago (2012-10-19 21:19:22 UTC) #1

ricow1

The fact that this did not land and the fact that the buildbot is now ...

8 years, 2 months ago (2012-10-22 10:35:40 UTC) #2

ricow1

LGTM https://codereview.chromium.org/11189101/diff/2001/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): https://codereview.chromium.org/11189101/diff/2001/tools/testing/dart/test_options.dart#newcode565 tools/testing/dart/test_options.dart:565: 'opera'])) { I would indent this under 'ie9'

8 years, 2 months ago (2012-10-22 10:37:15 UTC) #3

ricow1

8 years, 2 months ago (2012-10-22 11:33:19 UTC) #4

On 2012/10/22 10:37:15, ricow1 wrote:
> LGTM
> 
>
https://codereview.chromium.org/11189101/diff/2001/tools/testing/dart/test_op...
> File tools/testing/dart/test_options.dart (right):
> 
>
https://codereview.chromium.org/11189101/diff/2001/tools/testing/dart/test_op...
> tools/testing/dart/test_options.dart:565: 'opera'])) {
> I would indent this under 'ie9'
I landed a temp fix making the bots green in r 13860

Expand Messages | Collapse Messages

Issue 11189101: Complete renaming of ie bots to ie9, to add ie10. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Messages