Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 11189086: Add debug info to the make_version python script. (Closed)

Created:
8 years, 2 months ago by ricow1
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add debug info to the make_version python script. Committed: https://code.google.com/p/dart/source/detail?r=13812

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M runtime/tools/make_version.py View 1 2 chunks +28 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ricow1
8 years, 2 months ago (2012-10-19 08:38:49 UTC) #1
ricow1
Ivan asked me to add debug info to the version script. This is pretty verbose, ...
8 years, 2 months ago (2012-10-19 08:40:21 UTC) #2
Ivan Posva
LGTM with comments. -Ivan https://codereview.chromium.org/11189086/diff/1/runtime/tools/make_version.py File runtime/tools/make_version.py (right): https://codereview.chromium.org/11189086/diff/1/runtime/tools/make_version.py#newcode16 runtime/tools/make_version.py:16: def getVersion(): Where is this ...
8 years, 2 months ago (2012-10-19 08:42:14 UTC) #3
ricow1
8 years, 2 months ago (2012-10-19 08:49:38 UTC) #4
ricow1
Done, PTAL https://codereview.chromium.org/11189086/diff/1/runtime/tools/make_version.py File runtime/tools/make_version.py (right): https://codereview.chromium.org/11189086/diff/1/runtime/tools/make_version.py#newcode16 runtime/tools/make_version.py:16: def getVersion(): On 2012/10/19 08:42:14, Ivan Posva ...
8 years, 2 months ago (2012-10-19 08:49:54 UTC) #5
Ivan Posva
LGTM -ip
8 years, 2 months ago (2012-10-19 08:50:46 UTC) #6
Mads Ager (google)
8 years, 2 months ago (2012-10-19 09:07:23 UTC) #7
LGTM, too

Powered by Google App Engine
This is Rietveld 408576698