Issue 11189040: Added a new Matcher, FeatureMatcher, that is a useful abstract base class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11189040: Added a new Matcher, FeatureMatcher, that is a useful abstract base class (Closed)

Created:
8 years, 2 months ago by gram

Modified:
8 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Added a new Matcher, FeatureMatcher, that is a useful abstract base class for creating custom matchers. Committed: https://code.google.com/p/dart/source/detail?r=14114

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -0 lines)			Patch
	M	pkg/unittest/core_matchers.dart	View	1	1 chunk	+51 lines, -0 lines	0 comments	Download
	M	pkg/unittest/test/matchers_test.dart	View	1	2 chunks	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/11189040/diff/1/pkg/unittest/core_matchers.dart File pkg/unittest/core_matchers.dart (right): https://codereview.chromium.org/11189040/diff/1/pkg/unittest/core_matchers.dart#newcode648 pkg/unittest/core_matchers.dart:648: * expect(inventoryItem, HasPrice(greaterThan(0))); HasPrice => new HasPrice?

8 years, 2 months ago (2012-10-17 19:53:05 UTC) #2