Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1118843004: Propagate failures from VirtualMemory::Commit. (Closed)

Created:
5 years, 7 months ago by koda
Modified:
5 years, 7 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, ricow1, kasperl
Visibility:
Public.

Description

Propagate failures from VirtualMemory::Commit. BUG=23314 Committed: https://code.google.com/p/dart/source/detail?r=45515

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M runtime/vm/pages.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/pages.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M runtime/vm/virtual_memory.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
5 years, 7 months ago (2015-05-04 23:33:28 UTC) #1
koda
Already reviewed on other branch; submitting.
5 years, 7 months ago (2015-05-05 00:00:58 UTC) #2
koda
5 years, 7 months ago (2015-05-05 00:01:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r45515 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698