Issue 11187063: Generate contains() method for list mixin only if not already defined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11187063: Generate contains() method for list mixin only if not already defined. (Closed)

Created:
8 years, 2 months ago by sra1

Modified:
8 years, 2 months ago

Reviewers:
Lasse Reichstein Nielsen, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Generate contains() method for list mixin only if not already defined. Committed: https://code.google.com/p/dart/source/detail?r=13828

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+300 lines, -23 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View		52 chunks	+112 lines, -4 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		51 chunks	+111 lines, -3 lines	0 comments	Download
M	lib/html/scripts/systemhtml.py	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	lib/html/scripts/systemnative.py	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	lib/html/scripts/templateloader.py	View		2 chunks	+12 lines, -10 lines	0 comments	Download
M	lib/html/src/_Collections.dart	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	lib/html/templates/html/dart2js/impl_Console.darttemplate	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/html/templates/html/impl/impl_Document.darttemplate	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/html/templates/html/impl/impl_DocumentFragment.darttemplate	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/html/templates/html/impl/impl_Element.darttemplate	View	1	4 chunks	+11 lines, -2 lines	0 comments	Download
M	lib/html/templates/html/impl/impl_Node.darttemplate	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/html/templates/html/impl/impl_NodeList.darttemplate	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	lib/html/templates/immutable_list_mixin.darttemplate	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	tests/html/queryall_test.dart	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	tests/html/typed_arrays_5_test.dart	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

sra1

Requires https://codereview.chromium.org/11195039/ to land first for the interceptor.

8 years, 2 months ago (2012-10-19 02:25:12 UTC) #1

Lasse Reichstein Nielsen

Dependency committed, waiting to see if tree stays green. LGTM (based primarily on the output). ...

8 years, 2 months ago (2012-10-19 07:00:27 UTC) #2

lgtm